fix(helm): use parenthesized tracing guards #14634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olix0r
changed the title
sfleen
approved these changes
Oct 17, 2025
sfleen
added a commit
that referenced
this pull request
Oct 20, 2025
Similar to #14634, This adds parenthesized guards for the control plane tracing values check Signed-off-by: Scott Fleener <[email protected]>
sfleen
added a commit
that referenced
this pull request
Oct 21, 2025
Similar to #14634, This adds parenthesized guards for the control plane tracing values check in the case where we upgrade with existing values. Signed-off-by: Scott Fleener <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If upgrading linkerd to the latest edge without using the latest values.yaml, the helm chart could blow up with a nil deref. This adds guards that ensure proper defaulting.